Skip to content

Remove redundant #available(iOS 12, *) checks - #19511

Merged
mokagio merged 1 commit into
trunkfrom
mokagio/remove-ios-12-available
Oct 26, 2022
Merged

Remove redundant #available(iOS 12, *) checks#19511
mokagio merged 1 commit into
trunkfrom
mokagio/remove-ios-12-available

Conversation

@mokagio

@mokagio mokagio commented Oct 25, 2022

Copy link
Copy Markdown
Contributor

They always return true since the deployment version is higher than iOS 12.

I was looking at #available statements as part of #19496 and realized we still has some of these laying around.

There are even #available(iOS 11, *) and below showing up in the project, but they are all in the Pods or in SnapshotHelper.swift, which is code generated.

Regression Notes

  1. Potential unintended areas of impact – N.A.
  2. What I did to test those areas of impact (or what existing automated tests I relied on) – N.A.
  3. What automated tests I added (or what prevented me from doing so) – N.A.

  • I have completed the Regression Notes.
  • I have considered adding unit tests for my changes. N.A.
  • I have considered adding accessibility improvements for my changes. N.A.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary. N.A.

They always return `true` since the deployment version is higher than
iOS 12.
@mokagio mokagio self-assigned this Oct 25, 2022
@mokagio mokagio added this to the 21.1 milestone Oct 25, 2022
@mokagio
mokagio requested a review from a team October 25, 2022 11:50
@wpmobilebot

Copy link
Copy Markdown
Contributor
You can test the changes in Jetpack from this Pull Request by:
  • Clicking here or scanning the QR code below to access App Center
  • Then installing the build number pr19511-16512f2 on your iPhone

If you need access to App Center, please ask a maintainer to add you.

@wpmobilebot

Copy link
Copy Markdown
Contributor
You can test the changes in WordPress from this Pull Request by:
  • Clicking here or scanning the QR code below to access App Center
  • Then installing the build number pr19511-16512f2 on your iPhone

If you need access to App Center, please ask a maintainer to add you.

@spencertransier spencertransier left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes look good to me :shipit:

@mokagio
mokagio merged commit dac23ee into trunk Oct 26, 2022
@mokagio
mokagio deleted the mokagio/remove-ios-12-available branch October 26, 2022 02:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants